sbp-hardfork #2

sbp-jm · 2026-04-28T06:53:56Z

sbp-jm commented

2026-04-28 06:53:56 +00:00

nach main!

sbp-jm added 32 commits 2026-04-28 06:53:59 +00:00

4709b9d1db fix: is_hidden boolean coercion and forum settings access

bf37e01eb0 fix: read forum attribute lazily inside extend callback

ca8c248870 fix: use Eloquent Collection in job — loadMissing does not exist on Support\Collection

c54f37349f fix: use Support\Collection for cachedGlobalPermission — pluck() returns plain Collection, not Eloquent

d8eebb183a fix: prevent ES CPU saturation from has_child scoring all posts

Without minimum_should_match=1 on the inner post bool query, Elasticsearch
defaults MSM to 0 whenever a filter clause is present. This caused has_child
to score every non-hidden post on every search request, saturating CPU on
shared ES nodes with large corpora (3.7M+ posts).

- Add BoolQuery subclass with create() override and minimumShouldMatch()
  (spatie/elasticsearch-query-builder 1.x uses `new self()` in create(),
  so subclassing requires overriding it)
- Set minimumShouldMatch(1) on the inner post query after adding the
  is_hidden filter, so only genuinely matching posts are scored
- Remove the operator('or') clause from buildShouldClauses() — with
  Turkish min_ngram=2, 'or' generates 2-gram tokens that match nearly
  every post, causing near-total index scans
- Add ES client timeouts (connect: 2s, query: 10s) to prevent Apache
  mod_php worker saturation when ES is slow or unreachable

80357e6a77 fix: include --staging in build conflict suggestions

08353d2473 perf: sort by date by default, skip scoring on field sorts

- Default sort changed from relevance to updated_at desc. This lets
  has_child use score_mode:none, which skips child scoring entirely
  and lets ES short-circuit early on large corpora.
- When a field sort is requested, score_mode is also none for the same
  reason. score_mode:sum is only used when sorting by relevance.
- track_total_hits:false avoids a full-index count on every query,
  allowing ES to stop once it has collected enough results.
- Strip all gambit operators (tag:foo, author:bar, is:unread, etc.)
  from the ES query string, not just is:private. Leaving them in caused
  operator:and to require the gambit tokens to appear literally in post
  content, producing zero results when gambits were combined with text.

557604e426 fix: retry fill ES queries on transient connection failure

2706ed6be0 fix: index discussion on rename

6bcd2becd5 fix: report actual failed item error in bulk seeding exception

c5643bed31 fix: default search sort to latest and keep dropdown label in sync

- Search with no explicit sort now defaults to latest (updated_at desc)
  on both backend and frontend, matching the forum UX expectation.
- "All discussions" link from the search box routes to /?q=...&sort=latest
  so the sort dropdown shows "Latest" immediately after submission.
- extendDiscussionState injects sort=-lastPostedAt into API params when
  no sort is present, keeping direct-URL navigation (?q=anan) consistent
  with the backend default.
- Backend guard changed from phpSortField===null to empty($sorts), which
  is the correct sentinel since $sorts is the authoritative ES sort list.

c55db0abd6 fix: show TerminalPost in search results when field sort is active or mostRelevantPost is unavailable

When params.q is set, Flarum core suppresses TerminalPost and only shows an
excerpt from mostRelevantPost. This leaves the info section empty when the post
is null (e.g. hidden/deleted first post in production) or when results are
ordered by a field sort where an excerpt is meaningless.

Extend DiscussionListItem.infoItems to:
- Replace excerpt with TerminalPost when a field sort (latest, oldest, top) is
  active — relevance excerpts are not meaningful when sorted by date/count.
- Fall back to TerminalPost when no excerpt was added (mostRelevantPost null).

0adaab5d84 fix: resolve analyzer mismatch with symmetric language analyzer and title field

Replace the asymmetric ngram (index) / language (search) setup on content
with a symmetric language analyzer at both index and search time, eliminating
zero-hit cases caused by stemmed tokens falling below min_gram (e.g. Turkish).

Add a title field to discussion documents with a title.autocomplete edge-ngram
subfield (min=2, max=15) for prefix instant search, and a flarum_title_search
analyzer (lowercase only) as its search-time counterpart.

Remove flarum_analyzer_partial / partial_search_filter / search_analyzer from
the content mapping — no longer needed with symmetric analysis.

Bump INDEX_COMPAT_VERSION to v3. Also fix MatchQuery::toArray() to serialize
the analyzer property which was stored but never emitted.

0f58abf141 feat: add title.autocomplete instant search path sorted by latest

When filter[autocomplete]=1 is present, bypass the full has_child query
and run a single MatchQuery on title.autocomplete (edge-ngram prefix match).
Results are sorted by updated_at desc to stay consistent with full search.

33d4946947 feat: stem exclusion admin setting and analyzer language selector improvements

Add a stem-exclusion textarea to the admin settings page. Words entered here
(one per line) are passed as stem_exclusion to the language analyzer, preventing
them from being stemmed. Requires a full re-index to take effect.

The two language-dependent fields (stem exclusion, min search length) are
disabled when CJK is selected, since neither applies to bigram analysis.

Settings are reordered: search-scope switches now appear above the language
block so the language-dependent fields sit directly below the language selector.

Replace the lowercase ES identifier labels in the language dropdown with proper
display names (e.g. "Brazilian Portuguese", "CJK (Chinese, Japanese, Korean)",
"Sorani (Kurdish)"). Drift detection now tracks stem exclusion instead of the
removed min_gram index setting.

f7d9935fb9 feat: suppress ES instant results when search-post-bodies is enabled

When searching inside comments is ON, the autocomplete dropdown now returns
nothing from ES (only usernames show). This avoids showing title-only matches
that are inconsistent with the full comment-body search results.

Also passes filter[autocomplete]=1 to the API so the server uses the fast
title.autocomplete path instead of the full has_child query.

d27d71ff72 style: apply prettier formatting to admin/index.ts

e92307cf16 build: commit compiled JS dist files for feat/analyzer-refactor branch

925ecb0e7c tune title autocomplete edge_ngram bounds

0fa8fb92eb ai forgot to commit

e7e4495306 rebuild compiled JS assets for analyzer selector

e3dfc04192 add low-boost title autocomplete match to full search

7cb4071a54 restore strong title match and keep prefix title fallback

7f282cdb84 merge local search fixes after pull

bce3258325 fix forum search route and rebuild compiled assets

bf90e3279e remove frontend default sort from discussion search state

3e2f3f9585 always use ES search on initial search page load

5774879331 fuzzy search in thread